Skip to content

fix: Llama3_1ChatWrapper types #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Llama3_1ChatWrapper types #350

wants to merge 1 commit into from

Conversation

@vlamanna
Copy link

@vlamanna vlamanna commented Sep 27, 2024

Description of change

Fix the type mismatch in the Llama3_1ChatWrapper constructor.

Fixes #349

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • [N/A] There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@vlamanna
fix: Llama3_1ChatWrapper types
840babc 
Fix the type mismatch in the Llama3_1ChatWrapper constructor.

Fix issue withcatai#349
@giladgd
Copy link
Member

giladgd commented Sep 29, 2024

Thanks for the PR!

The _specialTokensTextForPreamble parameter is internal and should not be exposed.
I fixed this issue by hiding the _specialTokensTextForPreamble option from the function signature in the transpiled types in #351.
I'll release it in the next few days.

@giladgd giladgd closed this Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

I cannot build my Typescript project when using v3.0.0

2 participants

@vlamanna @giladgd